Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest pipeline feature processor dropdown #7277

Merged
merged 6 commits into from
May 31, 2016
Merged

Ingest pipeline feature processor dropdown #7277

merged 6 commits into from
May 31, 2016

Conversation

BigFunger
Copy link
Contributor

@BigFunger BigFunger commented May 24, 2016 •
edited
Loading

Replaces #7146 (please see comments in this issue for details)
Fixes #7061

Now targets the feature/ingest-pipeline feature branch

Additional changes:

  • Moved the processor select into its own directive
  • Modified the box-shadow of the dropdown-menu to address a bug in safari
  • Changed all less variable names that started with @settings-filebeat-wizard to start with @settings-add-data-wizard instead

Edit 2016-5-31:
I modified the dependency from angular-ui-select' toui-select'. angular-ui-select was a clone of the official ui-select dependency and has not been updated.

@BigFunger BigFunger added review Feature:Add Data Add Data and sample data feature on Home labels May 24, 2016
@Bargs
Copy link
Contributor

Bargs commented May 24, 2016

Another weird quirk, this time it happens in chrome as well. When the select box is near the bottom of the page so that the dropdown opens above it, filtering causes the result to float part way up the page.

floatingprocessor

@Bargs
Copy link
Contributor

Bargs commented May 24, 2016

@BigFunger code looks good. Just need to resolve the above issue.

@Bargs Bargs assigned BigFunger and unassigned Bargs May 24, 2016
@BigFunger BigFunger mentioned this pull request May 31, 2016
Closed
@BigFunger BigFunger assigned Bargs and unassigned BigFunger May 31, 2016
@BigFunger
Copy link
Contributor Author

jenkins, test it

@Bargs
Copy link
Contributor

Bargs commented May 31, 2016

Pending tests passing, LGTM

@BigFunger BigFunger merged commit 60837e1 into elastic:feature/ingest-pipeline May 31, 2016
@BigFunger BigFunger mentioned this pull request May 31, 2016
Closed
@Bargs
Copy link
Contributor

Bargs commented May 31, 2016

🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Bargs Bargs

Labels
Feature:Add Data Add Data and sample data feature on Home review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigFunger @Bargs